<html>
<head><meta charset="utf-8"><title>review for #70743 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html">review for #70743</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204288280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204288280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204288280">(Jul 18 2020 at 06:59)</a>:</h4>
<p>I have a PR open around constants in match patterns, does anyone want to take over reviewing?</p>



<a name="204290199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204290199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204290199">(Jul 18 2020 at 07:59)</a>:</h4>
<p>oh it's that one</p>



<a name="204290202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204290202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204290202">(Jul 18 2020 at 07:59)</a>:</h4>
<p>maybe I need to take another look</p>



<a name="204290208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204290208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204290208">(Jul 18 2020 at 07:59)</a>:</h4>
<p>(could've asked me when it passed crater, since that's a pretty good confidence margin)</p>



<a name="204290263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204290263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204290263">(Jul 18 2020 at 08:00)</a>:</h4>
<p>huh is <code>Poison</code> new? never seen it before</p>



<a name="204290606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/204290606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#204290606">(Jul 18 2020 at 08:08)</a>:</h4>
<p>poison is around half a year old I think. we're using it for synthetic places (e.g. when we read from a zst but miri is expecting a place)</p>



<a name="206668260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/206668260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#206668260">(Aug 12 2020 at 07:55)</a>:</h4>
<p>re-request for this PR</p>



<a name="206668312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/206668312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#206668312">(Aug 12 2020 at 07:55)</a>:</h4>
<p>It's a major refactoring with functional changes, but I have pulled out all the changes that are doable individually into separate PRs already and don't think we can really do better than that huge diff.</p>



<a name="206668379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370743/near/206668379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370743.html#206668379">(Aug 12 2020 at 07:56)</a>:</h4>
<p>all the actually critical code changes are in src/librustc_mir_build/thir/pattern/const_to_pat.rs (300 LOC according to github), but there's a huge amount of ui tests to review</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>